[dclong]

Summary

• build(rust-utils): set OPENSSL_NO_VENDOR when installing cargo packages

Changed files

Modified

• rust-utils/Containerfile (+2/-1)

Commits

• b8c0098 build(rust-utils): set OPENSSL_NO_VENDOR when installing cargo packages

[dclong]

Claude finished @dclong's task in 1m 16s —— View job

---

Code Review: build(rust-utils): set OPENSSL_NO_VENDOR when installing cargo packages

• Gather context (diff, repo conventions)
• Understand the request
• Review the change
• Post final review

Diff

-RUN OPENSSL_NO_VENDOR=1 RUSTFLAGS="-C strip=symbols" cargo install --locked \
+ENV OPENSSL_NO_VENDOR=1
+RUN RUSTFLAGS="-C strip=symbols" cargo install --locked \
         sccache cargo-binstall \
     && cargo-binstall -y --locked \
         cargo-cache cargo-edit cargo-criterion \

Analysis

• Correctness fix, not just a style change. In the original line, OPENSSL_NO_VENDOR=1 was a per-command env prefix that applied only to the immediately following simple command (cargo install --locked sccache cargo-binstall). It did not apply to the chained cargo-binstall -y --locked cargo-cache cargo-edit ... command, nor to the later RUN cargo-binstall -y evcxr_jupyter / cargo build --release (nperf) steps further down in rust-utils/Containerfile:22 and rust-utils/Containerfile:26-31. Promoting it to an ENV makes it apply to every subsequent RUN in the build stage, which matches the PR's stated intent ("...when installing cargo packages", plural).
• No unintended leakage into other images. rust-utils is only ever consumed via COPY --from=quay.io/legendu/rust-utils:next ... in lint/Containerfile, jupyterhub-more/Containerfile, and rust-cicd/Containerfile — none of them use FROM rust-utils. Since COPY --from does not carry over ENV values from the source stage, this new ENV is scoped to the rust-utils image build only and doesn't affect the other Containerfiles.
• No security, logic, or style issues found. The change is minimal and well-scoped.

Verdict

Safe to merge — no correctness bugs or blocking issues found.

AUTO_MERGE_APPROVED