-
Notifications
You must be signed in to change notification settings - Fork 13
documentation improvements #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @ManuelHu for working on this! @legend-exp/remage-software please help with the review of the docs. |
| physics constructors. It mostly is based on the physics list implemented in | ||
| _MaGe_. It combines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not reference MaGe, in the end it's fairly standard. also we might revise it soon
| Penelope, polarized) | ||
| - Optional **optical physics** (scintillation, Cherenkov, absorption, Rayleigh, | ||
| WLS) | ||
| - Configurable **hadronic physics lists**, including high-precision neutron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "high-precision" is the right adjective here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I checked. NeutronHP really means high-precision neutrons
| setting this efficiency as in the stock process. This also matches our | ||
| expectation, as we do not expect that the emission of multiple photons in a WLS | ||
| material should be described by a Poisson distribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather remind that the G4 model is poisson, but in general this is not a good assumption as most materials can emit max 1 photon (i.e. bernoulli distribution), so we offer this option
| | Option | Description | | ||
| | -------------- | --------------------------------------------------- | | ||
| | `None` | No hadronic physics (**default**) | | ||
| | `QGSP_BIC_HP` | Quark-Gluon String + Binary Cascade + HP neutrons | | ||
| | `QGSP_BERT_HP` | QGSP with Bertini cascade + HP neutrons | | ||
| | `FTFP_BERT_HP` | Fritiof string model + Bertini + HP neutrons | | ||
| | `Shielding` | Optimized shielding list with HP neutrons (default) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is correct. is there a G4 page we can link?
| <project:../rmg-commands.md#rmgprocessesusegrabmayrsgammacascades>, _remage_ | ||
| replaces the standard neutron capture process (`nCapture`) with a custom one | ||
| that will generate gamma cascaded for specific isotopes from files as provided | ||
| by P. Grabmayr _et al._. For all other isotopes, this process exactly behaves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to reference literature here. Help @MoritzNeuberger
|
(just for reference: I mark the comments as resolved when I resolved them locally, I will push later) |
|
Could you also add a warning box in the docs regarding the performance of |
No description provided.