Skip to content

Conversation

@ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Dec 4, 2025

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 34.52381% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.12%. Comparing base (974fc1b) to head (6a8eaba).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/reboost/optmap/convolve.py 25.67% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   71.24%   70.12%   -1.13%     
==========================================
  Files          33       33              
  Lines        2424     2497      +73     
==========================================
+ Hits         1727     1751      +24     
- Misses        697      746      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gipert
Copy link
Member

gipert commented Dec 4, 2025

can you add a test?

@ManuelHu
Copy link
Contributor Author

ManuelHu commented Dec 4, 2025

sure. this is also probably just the start of my fixes

@rosannadeckert
Copy link

it should be "all" here

detid = f"channels/{detid}" if detid != all and not detid.startswith("channels/") else detid

@ManuelHu ManuelHu force-pushed the optmap-convolve branch 2 times, most recently from e1d611e to f92b8ad Compare December 8, 2025 09:46
@ManuelHu ManuelHu changed the title optical map fixes optical map performance fixes Dec 8, 2025
* switch to custom implementation of np.digitize()
* move ak.ArrayBuilder usage into numba-optimized functions
@ManuelHu ManuelHu changed the title optical map performance fixes optmap: split up convolving processors Dec 18, 2025
@ManuelHu
Copy link
Contributor Author

this should now be ready, documented and tested

@gipert
Copy link
Member

gipert commented Dec 18, 2025

great. can you merge and release a new version?

@ManuelHu ManuelHu merged commit 29d501d into main Dec 18, 2025
15 checks passed
@ManuelHu ManuelHu deleted the optmap-convolve branch December 18, 2025 10:38
@ManuelHu
Copy link
Contributor Author

I will do a final round of testing on NERSC before releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants