-
Notifications
You must be signed in to change notification settings - Fork 4
optmap: split up convolving processors #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 71.24% 70.12% -1.13%
==========================================
Files 33 33
Lines 2424 2497 +73
==========================================
+ Hits 1727 1751 +24
- Misses 697 746 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can you add a test? |
|
sure. this is also probably just the start of my fixes |
|
it should be "all" here reboost/src/reboost/optmap/mapview.py Line 98 in 2085bdb
|
e1d611e to
f92b8ad
Compare
* switch to custom implementation of np.digitize() * move ak.ArrayBuilder usage into numba-optimized functions
f92b8ad to
3e83c8d
Compare
3e83c8d to
eb27661
Compare
|
this should now be ready, documented and tested |
|
great. can you merge and release a new version? |
|
I will do a final round of testing on NERSC before releasing |
No description provided.