Support maximum current calculation with simulated pulse shape library #134
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 70.69% 70.48% -0.21%
==========================================
Files 31 31
Lines 2416 2494 +78
==========================================
+ Hits 1708 1758 +50
- Misses 708 736 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is now ready, the missing items are optional |
…st enough (and cant be used in njit)
tdixon97
force-pushed
the
vector_field
branch
from
abb2e56 to
035bbda
Compare
| r: ArrayLike, | ||
| z: ArrayLike, | ||
| template: ArrayLike, | ||
| pulse_shape_library: tuple[np.array, np.array, np.array], |
| r: ak.Array, | ||
| z: ak.Array, | ||
| template: np.array, | ||
| pulse_shape_library: tuple[np.array, np.array, np.array], |
There was a problem hiding this comment.
yes its correct, since you cant pass the class to a numba func
| start: float, | ||
| dt: float, | ||
| ) -> float: | ||
| """Get the value of the waveform at a certain index. |
There was a problem hiding this comment.
this docstring is out of date, but maybe it can be made very short since it's not even a public function?
|
let's merge this once the final polishing is done? |
Yes I think it is almost ready, it is also now been tested a bit by @SalehGiovanna |
|
brava |
2 participants
Some steps are needed to have this working
maximum_currentWe should also think about whether we still use the drift time map, whether we interpolate also in
phietc, how to combine with the surface simulation etc.