switch all hpge processors to use ak.Array and unit handelling

[tdixon97]

Still some things are ad-hoc. My general idea is to have the public API functions convert the units to some internal set to be used in processors.
What I am not sure of is if this will really get used with the procesing chain / config (@ManuelHu ?)

Warning: This PR contains quite some API changes to switch to the new conventions

[ManuelHu]

What I am not sure of is if this will really get used with the procesing chain / config

not yet. the parameters from the ak arrays are not stored into the lgdo for now...

Also ak.Array(..., attrs=...) is wrong; these attrs cannot be retreived any more. There is no way to do that in one line of code without being ugly.

a = ak.Array(np.array([1,2,4]), attrs={"unit": "m"})
ak.parameters(a)  # {}


a = ak.Array(np.array([1,2,4]))
a = ak.with_parameter(a, "unit", "m")
ak.parameters(a)  # {'unit': 'm'}

[tdixon97]

I do not understand

>>> ak.Array([1,2,3],attrs={"units":"kev"}).attrs
{'units': 'kev'}

works nicely

[tdixon97]

I think this is now fixed, but we should think about having much testing of the units handling. Eg for every processor:

• Is the right unit returned?
• Are the units used correctly (and not eg. just discarded)?

This will take time

[codecov]

Codecov Report

❌ Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.47%. Comparing base (bfb6178) to head (ca832a2).

Files with missing lines	Patch %	Lines
src/reboost/hpge/psd.py	93.75%	1 Missing ⚠️
src/reboost/units.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   68.44%   68.47%   +0.03%     
==========================================
  Files          31       31              
  Lines        2637     2630       -7     
==========================================
- Hits         1805     1801       -4     
+ Misses        832      829       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gipert]

I think this is good to go and can be merged now, any objection?

[ManuelHu]

The Code with `.attrs` is still not the right way I guess? (If I remember right, we continued the discussion elsewhere on Slack? - the attrs are not preserved in all cases, only parameters are) Am 1. November 2025 11:09:38 MEZ schrieb Luigi Pertoldi ***@***.***>:

…

gipert left a comment (legend-exp/reboost#121) I think this is good to go and can be merged now, any objection?

[gipert]

Ok let's wait until we properly test this

[tdixon97]

This is not ready yet, it's a rather large change and needs careful testing. Sent from Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Luigi Pertoldi ***@***.***> Sent: Saturday, November 1, 2025 11:52:19 AM To: legend-exp/reboost ***@***.***> Cc: Dixon, Toby ***@***.***>; Author ***@***.***> Subject: Re: [legend-exp/reboost] switch all hpge processors to use ak.Array and unit handelling (PR #121) ⚠ Caution: External sender [https://avatars.githubusercontent.com/u/20358192?s=20&v=4]gipert left a comment (legend-exp/reboost#121)<#121 (comment)> Ok let's wait until we properly test this — Reply to this email directly, view it on GitHub<#121 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET4YYJI6IVW4ECBHD77T32SGGHAVCNFSM6AAAAACHMDCPKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZWGIYDANRVHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[gipert]

We should try to make some progress here...