Skip to content

Conversation

@tdixon97
Copy link
Contributor

@tdixon97 tdixon97 commented Dec 20, 2025

This currently only works on the PRL data, supporting also more recent p14-p16 datasets is possible, but supporting both at the same time is ugly (maybe neccesary for now)

  • add plot targets to "all" rule?
  • docs
  • compute A/E in hit.py
  • rename valid hpge lookup routines

@tdixon97 tdixon97 assigned gipert and unassigned gipert Dec 20, 2025
@tdixon97 tdixon97 requested a review from gipert December 20, 2025 15:51
@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 59.58333% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.21%. Comparing base (23ce0ec) to head (9da5e38).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
workflow/src/legendsimflow/hpge_pars.py 65.25% 41 Missing ⚠️
...imflow/scripts/extract_hpge_current_pulse_model.py 0.00% 27 Missing ⚠️
workflow/src/legendsimflow/reboost.py 0.00% 11 Missing ⚠️
workflow/src/legendsimflow/utils.py 70.00% 6 Missing ⚠️
workflow/src/legendsimflow/aggregate.py 82.75% 5 Missing ⚠️
workflow/src/legendsimflow/metadata.py 76.19% 5 Missing ⚠️
workflow/src/legendsimflow/patterns.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   61.58%   61.21%   -0.37%     
==========================================
  Files          16       18       +2     
  Lines         807     1034     +227     
==========================================
+ Hits          497      633     +136     
- Misses        310      401      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tdixon97
Copy link
Contributor Author

tdixon97 commented Dec 20, 2025 via email

@tdixon97
Copy link
Contributor Author

tdixon97 commented Dec 21, 2025

@gipert I added some tests, but what I could do is a bit limited with the test-data we have. Eg. it was not really possible to test that both old and new formats will work.
But maybe its enough for now and we can try to integrate this into the simflow?

@gipert gipert marked this pull request as draft December 24, 2025 14:35
@gipert gipert changed the title Add a script to extract A/E model pars feat: extract A/E model parameters and compute it in hit.py Dec 24, 2025
@gipert gipert force-pushed the pulse_pars branch 2 times, most recently from 452eaa1 to 0990fed Compare December 24, 2025 16:15
@tdixon97 tdixon97 marked this pull request as ready for review December 27, 2025 18:11
@tdixon97
Copy link
Contributor Author

tdixon97 commented Dec 28, 2025 via email

@gipert
Copy link
Member

gipert commented Dec 28, 2025

ok, now the template max should be at 1. i moved some stuff in a separate function, otherwise i think the hit script looks readable at the moment, we can factor out more in the future if it becomes longer.

@gipert gipert merged commit a6ac35d into legend-exp:main Dec 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants