-
Notifications
You must be signed in to change notification settings - Fork 274
Use channelVersion objects instead of special permission ids #5622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
16dbc15
ef6bbf3
154ccb8
0f6513b
70778ea
a61be92
5f9a2d7
7299a84
a89d2dc
13abc92
9cab8cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,10 +161,9 @@ | |
| :licenses="includedLicenses" | ||
| /> | ||
| <SpecialPermissionsList | ||
| v-if="licenseAuditIsFinished && specialPermissions.length > 0" | ||
| v-if="licenseAuditIsFinished && channelVersionId" | ||
| v-model="checkedSpecialPermissions" | ||
| :channel-version-id="versionDetail && versionDetail.id" | ||
| :permission-ids="specialPermissions" | ||
| :channel-version-id="channelVersionId" | ||
| @update:allChecked="allSpecialPermissionsChecked = $event" | ||
| /> | ||
| <div class="country-area"> | ||
|
|
@@ -431,11 +430,17 @@ | |
| return channelVersion; | ||
| }); | ||
| const channelVersionId = computed(() => { | ||
| if (versionDetail.value?.id) { | ||
| return versionDetail.value.id; | ||
| } | ||
| return null; | ||
|
||
| }); | ||
| const { | ||
| isLoading: licenseAuditIsLoading, | ||
| isFinished: licenseAuditIsFinished, | ||
| invalidLicenses, | ||
| specialPermissions, | ||
| includedLicenses, | ||
| checkAndTriggerAudit: checkAndTriggerLicenseAudit, | ||
| } = useLicenseAudit(props.channel, currentChannelVersion); | ||
|
|
@@ -574,6 +579,7 @@ | |
| isCurrentVersionAlreadySubmitted, | ||
| canBeEdited, | ||
| displayedVersion, | ||
| channelVersionId, | ||
| canBeSubmitted, | ||
| publishedDataIsLoading, | ||
| publishedDataIsFinished, | ||
|
|
@@ -582,7 +588,6 @@ | |
| licenseAuditIsLoading, | ||
| licenseAuditIsFinished, | ||
| invalidLicenses, | ||
| specialPermissions, | ||
| includedLicenses, | ||
| onSubmit, | ||
| // Translation functions | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| @import '~material-icons/iconfont/material-icons.css'; | ||
| @import '~kolibri-design-system/lib/styles/common'; | ||
| @import '~kolibri-design-system/lib/styles/definitions'; | ||
|
||
|
|
||
| @font-face { | ||
| font-family: 'Noto Sans'; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just do
permissions.value = response, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, Thanks!