Fix textColor console warning #14007
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in favor of the default 'black'. Since KToolbar doesn't accept dynamic theme values, it didn't work in the first place, and caused many console warnings.
Contributor
Build Artifacts
|
AlexVelezLl
approved these changes
Dec 15, 2025
Member
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
No textColor console warning anymore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove invalid prop value in favor of the default '
black'.Since
KToolbardoesn't accept dynamic theme values, it didn't work in the first place, and caused many console warnings.There's a more robust fix in progress learningequality/kolibri-design-system#1153, but we don't yet know when it will be finished or released.