Fixes occasional error during pre-commit hook runs where the kolibri package.json was empty #13982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pre-commit hook.
Contributor
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slightly rejig api spec tools to prevent errors during the core-api-js pre-commit hook.
Previously the kolbiri package package.json was loaded in module scope, which caused weird interactions while running the build_kolibri_package script, which would rewrite the package.json file.
References
No issue - just observed in multiple pre-commit runs on Github Actions and locally.
Reviewer guidance
I confirmed this fixed a persistent and recurrent instance of this when running in #13981
The best way to check this works is to make a change within the kolibri NPM package and then try to commit it - then confirm that the hook runs without errors.