Skip to content

Reset selection after applying filter #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AllanOXDi wants to merge 4 commits into
base: release-v0.19.x
Choose a base branch
from
Open

Reset selection after applying filter #13880

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41aeabe
adds watch function to clear user selection
AllanOXDi Nov 6, 2025
64ae7df
resets selection after a search
AllanOXDi Nov 6, 2025
520d961
extract clearSelectedUsers logic into composable
AllanOXDi Nov 6, 2025
7a32fde
centrally managing the clearing of selected users
AllanOXDi Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion kolibri/plugins/facility/assets/src/views/users/UsersRootPage/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
import FilterTextbox from 'kolibri/components/FilterTextbox';
import PaginationActions from 'kolibri-common/components/PaginationActions';
import { ref, computed, getCurrentInstance, onMounted } from 'vue';
import { ref, computed, getCurrentInstance, onMounted, watch } from 'vue';
import { useRoute, useRouter } from 'vue-router/composables';
import commonCoreStrings from 'kolibri/uiText/commonCoreStrings';
import useKResponsiveWindow from 'kolibri-design-system/lib/composables/useKResponsiveWindow';
Expand Down Expand Up @@ -279,6 +279,12 @@
fetchClasses();
});
watch([numAppliedFilters, searchTerm], (newValues, oldValues) => {
if (newValues[0] !== oldValues[0] || newValues[1] !== oldValues[1]) {
clearSelectedUsers();
}
});
Copy link
Member

@nucleogenesis nucleogenesis Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here looks good to me. However the behavior needs to also apply to the NewUserPage and UsersTrashPage components.

You could look at putting this logic into the useUserManagement.js composable - looks like we have the search and numAppliedFilters and it also houses the list of selectedUsers - so might be able to feed 3 birds with 1 stone since the other user table pages use useUserManagement for these values.

function clearSelectedUsers() {
selectedUsers.value = new Set();
}
Expand Down
Loading