Distribute Rewards - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reward Pool Implementation Summary
What Was Done
1. Add Approved Spender Function
Implemented
add_approved_spenderfunction in the reward-pool contract to whitelist contract addresses that can distribute rewards.Key Features:
SpenderAddedeventFiles Modified:
contracts/reward-pool/src/lib.rs- Added function implementationcontracts/reward-pool/src/types.rs- AddedSpender(Address)to DataKey enumcontracts/reward-pool/src/test.rs- Added 5 comprehensive tests2. Fixed Distribute Reward Function
Corrected the order of validation checks in
distribute_rewardto ensure proper error messages.Fix Applied:
3. Fixed Test Issues
StellarAssetClientinitialization to use.address()method4. Project Configuration
.vscode/to.gitignorecontracts/targetdirectory5. CI Validation
cargo fmt)cargo clippy)cargo test)Test Coverage
add_approved_spender tests:
distribute_reward tests:
This PR closes #22