-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solver service #159
Solver service #159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 13 13
Lines 1451 1451
=======================================
Hits 1359 1359
Misses 92 92 Continue to review full report at Codecov.
|
challenger/index.js
Outdated
constructor (db, ...args) { | ||
super(...args); | ||
this.db = db; | ||
// this.restoreSolutions(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't use storage, we can delete that part?
Though, what about storing the block height of the last processed event and storing that?
We can use that to replay events from that last known height on restart 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on removing. Replay sounds like a good idea, but not really sure if it should be in the scope of this bounty. Up to @johannbarbie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope, but nice to have. if some-one cares to garden it, plz do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some question :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍦🍯😋
yarn.lock
has a merge conflict, once this is resolved we can merge it
Based on ExecutionPoker
Resolves #116