Refactor out cmip specific tools #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@norlandrhagen should we merge this and release? |
|
Looks great! |
|
Ewww this was more of a mess then I anticipated. Need to write some proper tests (for everything not involving big query that is) -> #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@norlandrhagen I have tried to separate tools that are CMIP specific (e.g. iid specific stuff) from general cataloging. I have a hard time devising tests for anything bigquery, could you maybe test this on your end before we merge?
Note: I hate having the tests for https://github.com/leap-stc/cmip6-leap-feedstock in here, but I saw no other convinient way to reuse them (more on that coming up later). Ultimately we might have to turn https://github.com/leap-stc/cmip6-leap-feedstock into an installable package too and move these things back.