Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing pyrs in the data viewer #5

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

norlandrhagen
Copy link
Contributor

No description provided.

@andersy005
Copy link
Contributor

@norlandrhagen, do you have admin priviledges in the leap-stc organization? if so, you will need to install the leap-catalog app in this repo: https://github.com/apps/leap-stc-catalog/installations/56826523

otherwise, we will need @jbusecke's help

@norlandrhagen
Copy link
Contributor Author

@andersy005 I just added this repo to the list.

@andersy005 andersy005 temporarily deployed to test-pyr-dataviewer December 14, 2024 00:48 — with GitHub Actions Inactive
@leap-stc-catalog leap-stc-catalog bot temporarily deployed to test-pyr-dataviewer December 14, 2024 00:48 Inactive
@andersy005 andersy005 temporarily deployed to test-pyr-dataviewer December 14, 2024 00:57 — with GitHub Actions Inactive
@andersy005 andersy005 temporarily deployed to test-pyr-dataviewer December 14, 2024 01:34 — with GitHub Actions Inactive
@leap-stc-catalog leap-stc-catalog bot temporarily deployed to test-pyr-dataviewer December 14, 2024 01:35 Inactive
@leap-stc-catalog leap-stc-catalog bot temporarily deployed to test-pyr-dataviewer December 14, 2024 02:41 Inactive
@leap-stc-catalog leap-stc-catalog bot temporarily deployed to test-pyr-dataviewer December 14, 2024 02:42 Inactive
@andersy005
Copy link
Contributor

andersy005 commented Dec 14, 2024

everything seems to be working fine except the data viewer :(.

@katamartin, do you happen to have some ideas on how to circumvent CORS issue (in data-viewer) when trying to visualize pyramids hosted on a server we don't control?

for e.g. https://ncview-js.staging.carbonplan.org/?dataset=https://nyu1.osn.mghpcc.org/leap-pangeo-pipeline/CHIRPS/CHIRPS_pyramid_5_lvls.zarr doesn;t work because of CORS issues.

P.S.

the raw dataset works because we are proxying everything through the zarr-proxy: https://ncview-js.staging.carbonplan.org/?dataset=https://nyu1.osn.mghpcc.org/leap-pangeo-pipeline/chirps_feedstock/chirps-global-daily.zarr

@katamartin
Copy link

Hmmm good question! We have already set up a serverless function to handle CORS issues for the initial .zmetadata request (the only request we need to make directly for zarr-proxy-ed utilities).

I think we should be able to extend that pattern and pass a proxied URL @carbonplan/maps to handle pyramid tile requests. Looking our Vercel billing, I think the cost of handling those requests for a few pyramids should be negligible. So I think the main issue would be the 4.5 MB request body limit, which means that this pattern would break for pyramids that contain large tiles (which they hopefully don't for visualization performance in general). Do you know if the size limit would affect this pyramid?

Taking a step back, it would be ideal to give guidance that CORS be enabled for visualization-ready pyramids. Since the pyramid optimization is especially helpful to browser environments.

@norlandrhagen
Copy link
Contributor Author

Taking a step back, it would be ideal to give guidance that CORS be enabled for visualization-ready pyramids. Since the pyramid optimization is especially helpful to browser environments.

To add a bit, I am storing the pyramid on LEAP's OSN bucket, which I have no idea how CORS would works for that.

@andersy005
Copy link
Contributor

Taking a step back, it would be ideal to give guidance that CORS be enabled for visualization-ready pyramids. Since the pyramid optimization is especially helpful to browser environments.

➕ ....

@jbusecke, does OSN expose a web console to the admins? If so, it is worth investigating to see if we can enable CORS similar to how AWS exposes this feature: https://docs.aws.amazon.com/AmazonS3/latest/userguide/enabling-cors-examples.html

@andersy005 andersy005 temporarily deployed to test-pyr-dataviewer December 16, 2024 20:47 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants