Skip to content

[NKIFE-423] fix reduce_cmd default value #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

[NKIFE-423] fix reduce_cmd default value #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions KLR/Trace/ISA.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ nki builtin.isa.activation
(scale : Sum Immediate Access := .inl $ .float 1.0) -- This also can accept a tensor
(reduce_op : Option AluOp := none)
(reduce_res : Option Access := none)
(reduce_cmd : AccumCmd := .Idle)
(reduce_cmd : AccumCmd := .ZeroAccumulate)
(mask : Option Immediate := none)
(name : Option String := none) := do
if mask.isSome then
Expand All @@ -220,7 +220,6 @@ nki builtin.isa.activation_reduce
-- kwargs
(reduce_op : Option AluOp := none)
(reduce_res : Option Access := none)
(reduce_cmd : AccumCmd := .Idle)
(bias : Option Access := none )
(scale : Sum Immediate Access := .inl $ .float 1.0)
(mask : Option Immediate := none)
Expand All @@ -239,7 +238,7 @@ nki builtin.isa.activation_reduce
bias := bias.map .abstract,
reduceOp := reduce_op,
reduceRes := reduce_res.map .abstract,
accumulatorCmd := reduce_cmd,
accumulatorCmd := .ZeroAccumulate,
dtype := dst.tensor.dtype,
}) name
return .none
Expand Down