Skip to content

fix(client): match lean-i18n escaping in translation keys #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TentativeConvert merged 1 commit into from
Oct 2, 2026
Merged

fix(client): match lean-i18n escaping in translation keys #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions client/src/utils/translation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,10 @@ export function useGameTranslation(): UseTranslationResponse<'translation', unde
const modifiedT = ((key: string | undefined) => {
if (!key) return ""
const { codeBlocks, key: keyWithoutBlocks } = extractCodeBlocks(key)
// look-up the unmodified `key` in case of failure for backwards compatibility.
let translatedKey = gameT([keyWithoutBlocks, key], {ns: gameId})
// lean-i18n doubles backslashes outside code blocks in catalog keys.
const escapedKey = keyWithoutBlocks.replace(/\\/g, '\\\\')
// Keep the older placeholder and raw keys as fallbacks for existing catalogs.
let translatedKey = gameT([escapedKey, keyWithoutBlocks, key], {ns: gameId})
return translatedKey.replace(pattern, (_, num: string) => codeBlocks[Number(num)] ?? num);
}) as typeof t
return { t: modifiedT, i18n, ...rest }
Expand Down
Loading