Skip to content

Conversation

@unnawut
Copy link
Collaborator

@unnawut unnawut commented Aug 6, 2025

🗒️ Description

Introducing the 1st draft of the container specs for pqdevnet-0.

🔗 Related Issues or PRs

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx --with=tox-uv tox
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

@unnawut unnawut changed the title feat: 1st draft pqdevnet0 feat: 1st draft container specs for pqdevnet0 Aug 6, 2025
@unnawut unnawut changed the title feat: 1st draft container specs for pqdevnet0 feat: 1st draft container specs for pqdevnet-0 Aug 6, 2025
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @unnawut. This looks good to me. It would be nice to try to share some types that the execution-specs team put together specifically for Ethereum types. I added that as a comment here. That would help with homogeneity across spec repos for users and for spec readers.

I'm also not sure if the pqdevnet should be under subspecs but feel free to arrange these dirs however you see best. If these are more general types, perhaps they belong under the lean_spec directory. But there's no reason they can't be moved to a broader scope when it makes sense to.

@unnawut
Copy link
Collaborator Author

unnawut commented Aug 6, 2025

From interop call Guillaume pointed out that zeam uses the union type for optional field which makes sense.

I'll try it out and update this PR accordingly.

@unnawut unnawut marked this pull request as draft August 6, 2025 14:37
@fselmo
Copy link
Contributor

fselmo commented Aug 6, 2025

@unnawut ethereum/py-ssz also includes some relevant types that can potentially be leveraged here. I wonder at what point it makes sense to move these to ethereum-types as well but at least for now, things like List with max length, bitlist, etc could be useful. I would still pull things like U64, and whatever is already available, from ethereum-types, rather than py-ssz, to better align with the execution-specs types.

You can ignore my comment about moving types into ethereum-types (unless it makes sense for you to add more types there) as that's out of the scope for you and more of a thought for Python maintainers. But if it makes sense to use these types, that can also be a dependency that can be used in this repo and if they move, we can update here when the time comes.


edit: I also ran the github workflow which triggered some fails on lint / formatting. I gave you write permissions here as well so this should run automatically for you on subsequent PRs.

@unnawut unnawut changed the title feat: 1st draft container specs for pqdevnet-0 pqdevnet0: container specs Aug 13, 2025
@unnawut unnawut mentioned this pull request Aug 13, 2025
3 tasks
@unnawut
Copy link
Collaborator Author

unnawut commented Aug 13, 2025

Closing in favor of #8. Will reopen this PR when there's more clarity around the specs format.

@unnawut unnawut closed this Aug 13, 2025
@unnawut unnawut deleted the pqdevnet0 branch October 7, 2025 08:06
@unnawut unnawut added the specs Scope: Changes to the specifications label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specs Scope: Changes to the specifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants