-
Notifications
You must be signed in to change notification settings - Fork 31
pqdevnet0: container specs #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fselmo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @unnawut. This looks good to me. It would be nice to try to share some types that the execution-specs team put together specifically for Ethereum types. I added that as a comment here. That would help with homogeneity across spec repos for users and for spec readers.
I'm also not sure if the pqdevnet should be under subspecs but feel free to arrange these dirs however you see best. If these are more general types, perhaps they belong under the lean_spec directory. But there's no reason they can't be moved to a broader scope when it makes sense to.
|
From interop call Guillaume pointed out that zeam uses the union type for optional field which makes sense. I'll try it out and update this PR accordingly. |
|
@unnawut ethereum/py-ssz also includes some relevant types that can potentially be leveraged here. I wonder at what point it makes sense to move these to You can ignore my comment about moving types into edit: I also ran the github workflow which triggered some fails on lint / formatting. I gave you write permissions here as well so this should run automatically for you on subsequent PRs. |
|
Closing in favor of #8. Will reopen this PR when there's more clarity around the specs format. |
🗒️ Description
Introducing the 1st draft of the container specs for pqdevnet-0.
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx --with=tox-uv tox