Skip to content

fix(section_list): add spinlock for free list and fix use-after-unmap #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xfullex wants to merge 2 commits into from
Closed

fix(section_list): add spinlock for free list and fix use-after-unmap #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e40e88e
fix(section_list): add spinlock for free list and fix use-after-unmap
0xfullex Jan 6, 2026
0ead381
Merge branch 'main' into fix/section-list-race-conditions
leafok88 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/section_list.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "user_list.h"
#include <errno.h>
#include <fcntl.h>
#include <pthread.h>
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
Expand Down Expand Up @@ -78,6 +79,9 @@ typedef struct article_block_pool_t ARTICLE_BLOCK_POOL;
static char article_block_shm_name[FILE_NAME_LEN];
static ARTICLE_BLOCK_POOL *p_article_block_pool = NULL;

/* Spinlock for protecting free list operations */
static pthread_spinlock_t free_list_spinlock;

static char section_list_shm_name[FILE_NAME_LEN];
SECTION_LIST_POOL *p_section_list_pool = NULL;

Expand All @@ -102,6 +106,13 @@ int article_block_init(const char *filename, int block_count)
return -1;
}

/* Initialize spinlock for free list protection */
if (pthread_spin_init(&free_list_spinlock, PTHREAD_PROCESS_PRIVATE) != 0)
{
log_error("pthread_spin_init error");
return -1;
}

if (block_count <= 0 || block_count > ARTICLE_BLOCK_PER_POOL)
{
log_error("article_block_count exceed limit %d", ARTICLE_BLOCK_PER_POOL);
Expand Down Expand Up @@ -310,13 +321,18 @@ int detach_article_block_shm(void)

p_article_block_pool = NULL;

/* Destroy spinlock */
pthread_spin_destroy(&free_list_spinlock);

return 0;
}

inline static ARTICLE_BLOCK *pop_free_article_block(void)
{
ARTICLE_BLOCK *p_block = NULL;

pthread_spin_lock(&free_list_spinlock);

if (p_article_block_pool->p_block_free_list != NULL)
{
p_block = p_article_block_pool->p_block_free_list;
Expand All @@ -325,13 +341,19 @@ inline static ARTICLE_BLOCK *pop_free_article_block(void)
p_block->article_count = 0;
}

pthread_spin_unlock(&free_list_spinlock);

return p_block;
}

inline static void push_free_article_block(ARTICLE_BLOCK *p_block)
{
pthread_spin_lock(&free_list_spinlock);

p_block->p_next_block = p_article_block_pool->p_block_free_list;
p_article_block_pool->p_block_free_list = p_block;

pthread_spin_unlock(&free_list_spinlock);
}

int article_block_reset(void)
Expand Down