leafok · leafok88 · Dec 18, 2025 · Dec 3, 2025 · Dec 4, 2025 · Dec 16, 2025
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
@@ -0,0 +1,41 @@
+# LBBS — Copilot Instructions
+
+Short, specific pointers to help an AI coding agent be productive in this repo.
+
+**Build & Test**
+- **Install deps**: libssh, libpcre2 and a MySQL/MariaDB client dev package (e.g., libssh-dev, libpcre2-dev, libmariadb-dev or libmysqlclient-dev). CI also installs `libsystemd-dev`.
+- **Build**: `autoreconf --install --force` then `./configure --enable-systemd --disable-silent-rules` and `make`.
+- **Run tests**: `make check` (tests are custom binaries built under `src/`, e.g. `test_trie_dict`). CI runs `make check` and `make distcheck` (see [.github/workflows/makefile.yml](.github/workflows/makefile.yml#L1-L40)).
+
+**Run & Debug**
+- **Server binary**: `src/bbsd` (entry: [src/main.c](src/main.c#L1-L60)).
+- **Run in foreground**: `src/bbsd -f` (use `--display-log`/`--display-error-log` to redirect logs to stderr).
+- **Debug**: run with `gdb --args src/bbsd -f` or attach to the process; logs are in `log/`.
+
+**High-level architecture**
+- **Process**: `bbsd` (server) loads config and data files at start, initializes shared pools, listens for telnet/ssh clients and spawns handlers.
+- **Networking**: accept loop and client lifecycle are in [src/net_server.c](src/net_server.c#L1-L140); user-facing shuttle/menu networking is in [src/bbs_net.c](src/bbs_net.c#L1-L60).
+- **IO / Encoding**: terminal IO and non-blocking I/O are handled in [src/io.c](src/io.c#L1-L80). The project supports epoll/poll (conditional) and uses iconv for charset conversion. Default charset is `UTF-8`.
+- **Auth & DB**: login and auth live in [src/login.c](src/login.c#L1-L40); database access is in [src/database.c](src/database.c#L1-L40). DB credentials are read from `conf/bbsd.conf` (example in [conf/bbsd.conf](conf/bbsd.conf#L1-L40)).
+
+**Config & runtime files**
+- **Configs**: `conf/` contains runtime config (e.g., `conf/bbsd.conf`, `conf/bbsnet.conf`). Config constants are centralized in [src/common.c](src/common.c#L1-L40) as `CONF_*`.
+- **b b snet format**: each line is `ORG SITE HOST PORT USE_SSH(Y/N) CHARSET` (see how it's parsed in [src/bbs_net.c](src/bbs_net.c#L88-L118)).
+- **SSH keys**: host keys live in `conf/` (see `SSH_HOST_*` constants in [src/common.c](src/common.c#L1-L40)).
+- **Data & runtime**: static text files in `data/`; generated runtime files and caches in `var/`; logs in `log/`.
+
+**Project patterns and conventions**
+- **Autotools**: use `autoconf/automake` (`configure.ac`, `Makefile.am`); prefer `autoreconf` + `./configure` for local iterations.
+- **Tests**: tests are small programs named `test_*` in `src/` and are exercised by `make check`. Add new tests as `test_<feature>.c` and register in `src/Makefile.am`.
+- **Error/logging**: prefer `log_common()` / `log_error()` instead of printing to stdout. Most functions return negative on error.
+- **Globals & constants**: global config names use prefixes like `BBS_`, `VAR_`, `CONF_` (see [src/common.c](src/common.c#L1-L80)).
+
+**When changing networking/IO code**
+- Run `make check` and manually run `src/bbsd -f` to exercise interactive code paths.
+- For SSH-related changes, ensure `libssh` is present and try `test_ssh_server` in `src/`.
+- For charset changes, check `io.c` and the per-connection iconv usage (see [src/bbs_net.c](src/bbs_net.c#L250-L320)).
+
+**CI & packaging**
+- CI uses Ubuntu runners, installs system packages and runs `./configure`, `make`, `make check`, `make distcheck` (see [.github/workflows/makefile.yml](.github/workflows/makefile.yml#L1-L80)).
+
+If any of these sections look incomplete or you want more examples (e.g., walk-through for adding a test or adding a `configure` option), tell me which area to expand. I can iterate. (Drafted by AI; please confirm tone and level of detail.)
diff --git a/conf/lbbs.logrotate.in b/conf/lbbs.logrotate.in
@@ -1,7 +1,7 @@
 @prefix@/log/*.log {
     daily
     missingok
-    compress
+    rotate 90
     delaycompress
     notifempty
     create 640 bbs bbs

diff --git a/configure.ac b/configure.ac
@@ -2,7 +2,7 @@
 # Process this file with autoconf to produce a configure script.
 
 AC_PREREQ([2.69])
-AC_INIT([lbbs],[1.6.2])
+AC_INIT([lbbs],[1.6.3])
 AC_CONFIG_SRCDIR([src/])
 AC_CONFIG_HEADERS([config.h])
 AC_CONFIG_MACRO_DIRS([m4])

diff --git a/include/article_favor.h b/include/article_favor.h
@@ -44,7 +44,7 @@ extern int article_favor_check(int32_t aid, const ARTICLE_FAVOR *p_favor);
 // Set specific article as favorite
 extern int article_favor_set(int32_t aid, ARTICLE_FAVOR *p_favor, int state);
 
-extern int query_favor_articles(ARTICLE_FAVOR *p_favor, int page_id, ARTICLE **p_articles,
+extern int query_favor_articles(ARTICLE_FAVOR *p_favor, int page_id, const ARTICLE **p_articles,
 								char p_snames[][BBS_section_name_max_len + 1], int *p_article_count, int *p_page_count);
 
 #endif //_ARTICLE_FAVOR_H_
diff --git a/include/hash_dict.h b/include/hash_dict.h
@@ -39,9 +39,16 @@ typedef struct hash_dict_t HASH_DICT;
 extern HASH_DICT *hash_dict_create(int item_count_limit);
 extern void hash_dict_destroy(HASH_DICT *p_dict);
 
+// Return 1 if existing key updated, 0 if new key added, -1 on error
 extern int hash_dict_set(HASH_DICT *p_dict, uint64_t key, int64_t value);
+
+// Return 1 if existing key updated, 0 if key not exist, -1 on error
 extern int hash_dict_inc(HASH_DICT *p_dict, uint64_t key, int64_t value_inc);
+
+// Return 1 if key found, 0 if key not exist, -1 on error
 extern int hash_dict_get(HASH_DICT *p_dict, uint64_t key, int64_t *p_value);
+
+// Return 1 if key deleted, 0 if key not exist, -1 on error
 extern int hash_dict_del(HASH_DICT *p_dict, uint64_t key);
 
 inline unsigned int hash_dict_item_count(HASH_DICT *p_dict)

diff --git a/include/log.h b/include/log.h
@@ -13,8 +13,9 @@
 
 enum log_level_t
 {
-	LOG_LEVEL_COMMON = 1,
-	LOG_LEVEL_ERROR = 2,
+	LOG_LEVEL_COMMON,
+	LOG_LEVEL_ERROR,
+	LOG_LEVEL_DEBUG,
 };
 
 extern int log_begin(const char *common_log_file, const char *error_log_file);
@@ -25,6 +26,12 @@ extern int log_printf(enum log_level_t log_level, const char *app_file, int app_
 #define log_common(...) log_printf(LOG_LEVEL_COMMON, __FILE__, __LINE__, __VA_ARGS__)
 #define log_error(...) log_printf(LOG_LEVEL_ERROR, __FILE__, __LINE__, __VA_ARGS__)
 
+#ifdef _DEBUG
+#define log_debug(...) log_printf(LOG_LEVEL_DEBUG, __FILE__, __LINE__, __VA_ARGS__)
+#else
+#define log_debug(...) ((void)0)
+#endif
+
 extern int log_common_redir(int fd);
 extern int log_error_redir(int fd);
 

diff --git a/include/section_list_loader.h b/include/section_list_loader.h
@@ -42,7 +42,7 @@ extern int section_list_loader_launch(void);
 
 // Return on success : real page_id (>= 0)
 //           failure : error number (< 0)
-extern int query_section_articles(SECTION_LIST *p_section, int page_id, ARTICLE *p_articles[],
+extern int query_section_articles(SECTION_LIST *p_section, int page_id, const ARTICLE *p_articles[],
 								  int *p_article_count, int *p_page_count, int *p_ontop_start_offset);
 
 // Input direction =  0 : locate p_article_cur

diff --git a/src/article_cache.c b/src/article_cache.c
@@ -129,11 +129,9 @@ int article_cache_generate(const char *cache_dir, const ARTICLE *p_article, cons
 
 	if (header_len != cache.line_offsets[header_line_cnt])
 	{
-#ifdef _DEBUG
-		log_error("Header of article(aid=%d) is truncated from %ld to %ld\n, body_line=%ld, body_line_limit=%ld",
+		log_debug("Header of article(aid=%d) is truncated from %ld to %ld\n, body_line=%ld, body_line_limit=%ld",
 				  p_article->aid, header_len, cache.line_offsets[header_line_cnt],
 				  header_line_cnt, MAX_SPLIT_FILE_LINES);
-#endif
 		header_len = (size_t)cache.line_offsets[header_line_cnt];
 	}
 
@@ -147,11 +145,9 @@ int article_cache_generate(const char *cache_dir, const ARTICLE *p_article, cons
 
 	if (body_len != (size_t)cache.line_offsets[cache.line_total])
 	{
-#ifdef _DEBUG
-		log_error("Body of article(aid=%d) is truncated from %ld to %ld, body_line=%ld, body_line_limit=%ld\n",
+		log_debug("Body of article(aid=%d) is truncated from %ld to %ld, body_line=%ld, body_line_limit=%ld\n",
 				  p_article->aid, body_len, cache.line_offsets[cache.line_total],
 				  body_line_cnt, MAX_SPLIT_FILE_LINES - header_line_cnt);
-#endif
 		cache.data_len = header_len + (size_t)(cache.line_offsets[cache.line_total]);
 	}
 
@@ -165,11 +161,9 @@ int article_cache_generate(const char *cache_dir, const ARTICLE *p_article, cons
 
 	if (footer_len != cache.line_offsets[cache.line_total + footer_line_cnt])
 	{
-#ifdef _DEBUG
-		log_error("Footer of article(aid=%d) is truncated from %ld to %ld, footer_line=%ld, footer_line_limit=%ld\n",
+		log_debug("Footer of article(aid=%d) is truncated from %ld to %ld, footer_line=%ld, footer_line_limit=%ld\n",
 				  p_article->aid, footer_len, cache.line_offsets[cache.line_total + footer_line_cnt],
 				  footer_line_cnt, MAX_SPLIT_FILE_LINES - cache.line_total);
-#endif
 		footer_len = (size_t)(cache.line_offsets[cache.line_total + footer_line_cnt]);
 	}
 

diff --git a/src/article_favor.c b/src/article_favor.c
@@ -445,7 +445,7 @@ int article_favor_set(int32_t aid, ARTICLE_FAVOR *p_favor, int state)
 	return 1; // Set complete
 }
 
-int query_favor_articles(ARTICLE_FAVOR *p_favor, int page_id, ARTICLE **p_articles,
+int query_favor_articles(ARTICLE_FAVOR *p_favor, int page_id, const ARTICLE **p_articles,
 						 char p_snames[][BBS_section_name_max_len + 1], int *p_article_count, int *p_page_count)
 {
 	SECTION_LIST *p_section;

diff --git a/src/article_favor_display.c b/src/article_favor_display.c
@@ -56,7 +56,7 @@ static int article_favor_draw_screen(int display_sname)
 	return 0;
 }
 
-static int article_favor_draw_items(int page_id, ARTICLE *p_articles[], char p_snames[][BBS_section_name_max_len + 1],
+static int article_favor_draw_items(int page_id, const ARTICLE *p_articles[], char p_snames[][BBS_section_name_max_len + 1],
 									int article_count, int display_sname)
 {
 	char str_time[LINE_BUFFER_LEN];
@@ -172,7 +172,7 @@ static enum select_cmd_t article_favor_select(int total_page, int item_count, in
 		switch (ch)
 		{
 		case KEY_NULL: // broken pipe
-			log_error("KEY_NULL\n");
+			log_debug("KEY_NULL\n");
 		case KEY_ESC:
 		case KEY_LEFT:
 			return EXIT_LIST; // exit list
@@ -299,7 +299,7 @@ int article_favor_display(ARTICLE_FAVOR *p_favor)
 
 	char page_info_str[LINE_BUFFER_LEN];
 	char snames[BBS_article_limit_per_page][BBS_section_name_max_len + 1];
-	ARTICLE *p_articles[BBS_article_limit_per_page];
+	const ARTICLE *p_articles[BBS_article_limit_per_page];
 	int article_count;
 	int page_count;
 	int page_id = 0;

diff --git a/src/bbs_main.c b/src/bbs_main.c
@@ -171,9 +171,7 @@ int bbs_center()
 		if (ch != KEY_NULL && ch != KEY_TIMEOUT)
 		{
 			BBS_last_access_tm = time(NULL);
-#ifdef _DEBUG
-			log_error("Debug: BBS_last_access_tm is updated\n");
-#endif
+			log_debug("Debug: BBS_last_access_tm is updated\n");
 		}
 
 		if (bbs_menu.choose_step == 0 && time(NULL) - t_last_action >= 10)
@@ -194,7 +192,7 @@ int bbs_center()
 		switch (ch)
 		{
 		case KEY_NULL: // broken pipe
-			log_error("KEY_NULL\n");
+			log_debug("KEY_NULL\n");
 			loop = 0;
 			break;
 		case KEY_TIMEOUT: