Skip to content

Added add_headers() method to request objects #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkWiiPlayer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added add_headers() method to request objects #543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90d259f
Removed a line that did nothing
DarkWiiPlayer May 12, 2017
da12424
added `add_header()` method to request object
DarkWiiPlayer May 12, 2017
1a762aa
Fixed obvious mistake that made no sense at all
DarkWiiPlayer May 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lapis/request.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,11 @@ do
self.buffer = { }
self.params = { }
self.options = { }
local _ = {
[self.add_headers] = function(self, headers)
for k, v in pairs(headers) do
self.res:add_header(k, v)
end
self.add_headers = function(self, headers)
for k, v in pairs(headers) do
self.res:add_header(k, v)
end
}
end
self.__class.support.load_cookies(self)
return self.__class.support.load_session(self)
end,
Expand Down
2 changes: 1 addition & 1 deletion lapis/request.moon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class Request
@buffer = {} -- output buffer
@params = {}
@options = {}
@add_headers: (headers) =>
Copy link
Contributor Author

@DarkWiiPlayer DarkWiiPlayer May 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mistake is probably a side-effect of writing too much CSS during the days leading up to this commit

@add_headers = (headers) =>
for k,v in pairs headers
@res\add_header k,v

Expand Down