Skip to content

Custom class for label element #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Custom class for label element #220

wants to merge 1 commit into from

Conversation

livesega
Copy link

@livesega livesega commented Jan 12, 2018

Hi, in my work the "label" classes often intersect, it would be nice to be able to change the class to any other

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #220   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         391    391           
=====================================
  Hits          391    391
Impacted Files Coverage Δ
src/jquery.selectric.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b92c26...409fa85. Read the comment docs.

@gearsdigital
Copy link
Contributor

Thank you very much for your contribution! This is a nice enhancement :) But before I'm going to merge this could you improve your PR a bit?

  1. Please add a proper test case
  2. Do not increment the Version number (This will be done if we ship a new release)

Ideally you need to change only README.md and src/jquery.selectric.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants