-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bastion): add support for app connectors, exit nodes, and configurable tags #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Reviewed the entire pull request up to 5367496
- Looked at
479
lines of code in6
files - Took 2 minutes and 4 seconds to review
More info
- Skipped
1
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. provider/pkg/provider/aws/bastion.go:25
:
- Assessed confidence :
10%
- Comment:
The changes in this PR look good. The added support for app connectors and exit nodes is reflected correctly in the code and the SDKs. The tags have been made configurable as described in the PR description. - Reasoning:
The PR adds support for app connectors and exit nodes, and makes tags configurable. The changes are reflected in the schema, the SDKs for different languages, and the main provider code. The changes look good and there are no obvious bugs or violations of best practices.
Workflow ID: wflow_pbTI6AwrpESLRQsI
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on 39e3cf4
- Looked at
17
lines of code in1
files - Took 2 minutes and 41 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. schema.yaml:6
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The PR description mentions that the tags have been made configurable. However, I don't see any changes in this file that reflect this. Please ensure that the changes are correctly reflected in the schema. - Reasoning:
The PR description mentions that the tags have been made configurable. However, I don't see any changes in the schema.yaml file that reflect this. The tags were already present in the previous version of the schema. I need to check if the changes have been made in the code files.
Workflow ID: wflow_2Rl2sfrGr12HW8i2
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on f5f1565
- Looked at
12
lines of code in1
files - Took 1 minute and 22 seconds to review
More info
- Skipped
1
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. /sdk/python/setup.py:26
:
- Assessed confidence :
50%
- Comment:
The diff shows that a new line was added here, but there are no visible changes. Please double-check this. - Reasoning:
The PR diff shows that a new line was added to the setup.py file. However, the diff does not show any changes. This could be a mistake or a bug in the diff tool. I will comment on this to bring it to the attention of the PR author.
Workflow ID: wflow_O9VUW8XIzgkrH4wM
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on ce51360
- Looked at
181
lines of code in4
files - Took 2 minutes and 54 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. .github/workflows/main.yml:97
:
- Assessed confidence :
80%
- Grade:
0%
- Comment:
The Node.js version has been updated from 18.x to 21.x. Please ensure that all dependencies and the codebase itself are compatible with this new version. - Reasoning:
The Node.js version has been updated from 18.x to 21.x in the GitHub workflows. This could potentially introduce breaking changes if the codebase is not compatible with the new version. It's important to ensure that all dependencies and the codebase itself are compatible with this new version.
Workflow ID: wflow_Tky2449WBMhiWPXy
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on efc6fdf
- Looked at
16
lines of code in1
files - Took 1 minute and 48 seconds to review
More info
- Skipped
1
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. schema.yaml:183
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The PR description mentions that tags have been made configurable, but I don't see any changes in the schema.yaml file related to tags. Please ensure that the changes are reflected in the schema file as well. - Reasoning:
The PR description mentions that tags have been made configurable, but I don't see any changes in the schema.yaml file related to tags. I need to check if the changes are made in the code files.
Workflow ID: wflow_JkK67cXsdt1qHX79
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on 6922891
- Looked at
695
lines of code in11
files - Took 1 minute and 30 seconds to review
More info
- Skipped
2
files when reviewing. - Skipped posting
0
additional comments because they didn't meet confidence threshold of50%
.
Workflow ID: wflow_TfrUHhqJPoWsh2IQ
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Summary:
This PR adds support for app connectors and exit nodes, makes tags configurable, and updates the
schema.yaml
file, SDKs, and Node.js version in GitHub workflows.Key points:
schema.yaml
file, SDKs, and Node.js version in GitHub workflowsGenerated with ❤️ by ellipsis.dev