Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix position of share icon #860

Merged
merged 2 commits into from
Dec 22, 2024
Merged

fix position of share icon #860

merged 2 commits into from
Dec 22, 2024

Conversation

sudhanshutech
Copy link
Member

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@sudhanshutech
fix(shareIcon): fix position
be52d8b 
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech
fix(code): rm dead code
9147141 
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech
Copy link
Member Author

@amitamrutiya please approve this.

@amitamrutiya
Copy link
Contributor

@sudhanshutech make sure these icons are compatible with the dark mode as well.

@sudhanshutech
Copy link
Member Author

@sudhanshutech make sure these icons are compatible with the dark mode as well.

yes they already are.

@sudhanshutech sudhanshutech merged commit 9bbe475 into layer5io:master Dec 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitamrutiya amitamrutiya amitamrutiya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudhanshutech @amitamrutiya