Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mdx2 upgrade v3 #5925

Closed
wants to merge 73 commits into from
Closed

Mdx2 upgrade v3 #5925

wants to merge 73 commits into from

Conversation

Aviral0702
Copy link
Contributor

Description

This PR fixes #
Aims to migrate to MDX V2 and gatsby-plugin-mdx v4

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

randychilau added 30 commits July 19, 2023 21:23
@randychilau
Revert "Merge pull request layer5io#4580 from thisiskaransgit/revert-…
dd98947 
…4532-mdx2-upgrade"

This reverts commit 8362b4e, reversing
changes made to 4c2e586.

Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: .html check for already updated urls
322606a 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
feat: remind on page creation/url/redirect changes
d8e08ae 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
Merge 'master' into mdx2-upgrade-v3
9ba13f8 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
Merge branch 'master' into mdx2-upgrade-v3
b8ec8f5
@randychilau
fix: resize/optimize images with tiny-img
cb31caa 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: remove InlineQuote from shortcodes
e4c1b8f 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
Merge branch 'master' into mdx2-upgrade-v3
a6872c5
@randychilau
fix: remove hashtag char from url
d92ab45 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test : added new line
ae738b9 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: review mdx for large img, shortcodes, syntax
22bc224 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
merge: review merge changes for mdx issues
d0132c9 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: react style formatting for mdx
e0cca5e 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: gatsbyImageData layout and HEAD data import
aa9d061 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
Merge branch 'master' into mdx2-upgrade-v3
cad3a70 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: GATSBY_DEV_AMENDED=true
439d1d3 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: update config for mdx events
39d8eae 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: lhci build testing
5d77acb 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: Head component destructure imported data
5d26a25 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: only restrict members for memory heap issues
a80777e 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: remove GATSBY_DEV_AMENDED
b6982ee 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: optimize member images 500 width / webp
78c9aa0 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: remove unused data query n import correction
5342cb7 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: remove unused query from navigation
8510727 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: optimize integration meshmap images
f10dbfb 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: remove bubblesElement from footer
e4e292a 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
fix: optimize image size for members letter d
2a3f4c3 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: 80 members mdx pages
7bb7301 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: update member pages to 100
5dc21a1 
Signed-off-by: Randy Lau <[email protected]>
@randychilau
test: fix member cyrine gamoudi
2a9e0c2 
Signed-off-by: Randy Lau <[email protected]>
@sudhanshutech
Copy link
Member

@Aviral0702 merge conflicts

@sudhanshutech
Copy link
Member

where are the other build checks here?

sudhanshutech
sudhanshutech requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there is changes in md and yml files , i don't understand?

@sudhanshutech
Copy link
Member

@Aviral0702 will you explain the breaking changes here while migarte.

@Aviral0702
Copy link
Contributor Author

@Aviral0702 merge conflicts

Yes resolving those now.

@Aviral0702
Copy link
Contributor Author

why there is changes in md and yml files , i don't understand?

The older configurations of mdx files are not compatible with new rules of parsing mdx files in MDX V2. That is why we need to change the configuration here and if it works we will permanently change the configuration of these files.

@Aviral0702
incorporated latest changes
3d14471 
Signed-off-by: Aviral Asthana <[email protected]>
@sudhanshutech
Copy link
Member

why there is changes in md and yml files , i don't understand?

The older configurations of mdx files are not compatible with new rules of parsing mdx files in MDX V2. That is why we need to change the configuration here and if it works we will permanently change the configuration of these files.

so whats the status?

@sudhanshutech
Copy link
Member

please reply on all of the questions asked above .

@sudhanshutech
Copy link
Member

why there is changes in md and yml files , i don't understand?

The older configurations of mdx files are not compatible with new rules of parsing mdx files in MDX V2. That is why we need to change the configuration here and if it works we will permanently change the configuration of these files.

is it? i still don't understand why yml files are been changed here

@Aviral0702
Copy link
Contributor Author

@Aviral0702 merge conflicts

resolved.

@vishalvivekm
Copy link
Contributor

@Aviral0702 @sudhanshutech
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@vishalvivekm
Copy link
Contributor

I've added this to the agenda items @sudhanshutech @Aviral0702

leecalcote
leecalcote reviewed Oct 9, 2024
View reviewed changes
.github/workflows/lighthouseci.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing it. What changed in these files?

@vishalvivekm
Copy link
Contributor

@Aviral0702
Are we discussing updates on this PR today on websites' call ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@sudhanshutech sudhanshutech sudhanshutech requested changes

Assignees
No one assigned
Labels
area/blog New posts or new blog functionality area/careers area/ci area/community area/core-styles area/events area/learn Related to /learn section area/news A noteworthy article, event, happening area/projects An issue relating to Layer5 initiatives (projects) area/resources area/site-config project/kanvas project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aviral0702 @sudhanshutech @vishalvivekm @leecalcote @randychilau