[UI] Invalid read more button removed. #5817
Conversation
|
🚀 Preview for commit 5f8ee23 at: https://66bd0f714adcc41c087bdfef--layer5.netlify.app |
There was a problem hiding this comment.
@SyedAyaanAli6786, please fix the DCO sign-off. If you're unaware, read more about it in the contributing guide.
…Syed Ayaan Ali; [email protected] Signed-off-by: Syed Ayaan Ali <[email protected]>
SyedAyaanAli6786
force-pushed
the
master
branch
from
5f8ee23 to
994417a
Compare
|
🚀 Preview for commit 35fc558 at: https://66bf2bcbc24898ffdb946be1--layer5.netlify.app |
|
@SyedAyaanAli6786, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
@SyedAyaanAli6786, please join. The meeting has started. |
|
@Ashparshp Hello, I didn't saw this message of yours. I was a little busy today. I will surely join the next meeting. |
|
Thank you @SyedAyaanAli6786 for sending words, are you on slack? |
|
No @Ashparshp currently I'm not on slack, but I can join if you say. |
|
@SyedAyaanAli6786, yes please! |
|
@SyedAyaanAli6786, Joined? and also, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
Yes @Ashparshp joined slack. |
There was a problem hiding this comment.
@SyedAyaanAli6786 can you plesae increase the font-size for Read More ? It's barely visible.
|
@vishalvivekm, the ask was to remove the read more as it was invalid here. Please recheck the issue again. |
|
@SyedAyaanAli6786, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link. |
|
I'm adding this as an agenda item to the meeting minutes. Please join the evening call. |
|
Ok @Ashparshp, thanks for the invitation. I will be there at the meeting. Can you tell me what will be my role in the meeting (what will I tell) ? |
|
In the meeting, we discussed the PRs and updates on the work and provide feedback. This is the fastest way to move forward with the PRs. |
|
@SyedAyaanAli6786, any luck? |
|
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
1 similar comment
|
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
|
🚀 Preview for commit 2f0c04e at: https://670d2104e3e68c3792cfe3ee--layer5.netlify.app |
|
lgtm. @SyedAyaanAli6786 please ensure next time you get assigned for the issue before creating a pr. |
Description
This PR fixes #5814 using conditional rendering .
Notes for Reviewers
Signed commits