Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored MeshmapPage component to improve readability and performance #5470

Merged

Conversation

AbhisekOmkar
Copy link
Contributor

@AbhisekOmkar AbhisekOmkar commented Mar 31, 2024

  • Simplified destructuring of location object
  • Removed unused variables and imports
  • Fixed linting warnings
  • Updated comments for clarity
    Signed-off-by: Author Name [email protected]

@l5io
Copy link
Contributor

l5io commented Mar 31, 2024

🚀 Preview for commit 4c2167a at: https://66091b83773f528eec5ea2f6--layer5.netlify.app

Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@vishalvivekm
Copy link
Contributor

Thank you @AbhisekOmkar for this.
I don't see a corresponding issue open for which, this pull request is a proposed fix.
I understand that you may not have had the chance to go through the contributing guidelines and code of conduct outlined in the community handbook.
Please go through these documents and always first open issue, ask for assignment, and once assigned, proceed with raising a fix. I hope you'll keep them in mind for future contributions.
Also, this PR is missing the DCO.

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Mar 31, 2024

Also, We've our weekly websites meeting today[1st April, 5:30 PM IST]. Add this as an agenda item to the meeting minutes, if you would like to discuss the changes made.

@dragon-slayer875
Copy link

Hello @AbhisekOmkar. It seems that your commit is not signed.
To pass the DCO check, you need to sign your commit.
You can find more information about signing commits here.

@leecalcote
Copy link
Member

Thank you, @AbhisekOmkar 👍

@leecalcote leecalcote requested a review from iArchitSharma May 2, 2024 19:48
Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhisekOmkar Thank you

@iArchitSharma iArchitSharma merged commit 98fbdfc into layer5io:master May 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants