Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile screenshots #5384

Merged
merged 4 commits into from
Apr 13, 2024
Merged

Devfile screenshots #5384

merged 4 commits into from
Apr 13, 2024

Conversation

narasimha-1511
Copy link
Member

@narasimha-1511 narasimha-1511 commented Feb 8, 2024

Description
Please Review my PR
This PR fixes #4886

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Feb 8, 2024

🚀 Preview for commit 8ae83b8 at: https://65c4fdf93838cf2396dd18bc--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Hi @narasimha-1511 ,
Thanks for your PR! I encourage you to share this in the Website Meeting tomorrow at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.

You're welcome at the meeting

Check to community calendar for more details of meetings at Layers.

@saurabh100ni
Copy link
Contributor

@narasimha-1511, I guess you already know what needs to be changed here 😉

@narasimha-1511
Copy link
Member Author

changes done @saurabh100ni 😄

@l5io
Copy link
Contributor

l5io commented Feb 14, 2024

🚀 Preview for commit f3b9cfe at: https://65cc7c304419d787fb0f8004--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

@narasimha-1511, do you know what we do with that checkbox in PR description 👀?

@narasimha-1511
Copy link
Member Author

I have Signed my commits 😅 .

@narasimha-1511
Copy link
Member Author

hey @vishalvivekm this PR LGTM can you merge it?

@narasimha-1511
Copy link
Member Author

this PR LGTM @iArchitSharma

@@ -15,8 +15,8 @@ featureList: [
"Central location management so updates can be applied once and be properly aligned across development teams."
]
workingSlides: [
../_images/meshmap-visualizer.png,
../_images/meshmap-designer.png
../_images/meshmap-designer.png,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narasimha-1511 aren't the images supposed to be inside _images/devfile directory

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are inside devfile folder these images are automatically used in the integration from the folder you can see it here:https://65cc7c304419d787fb0f8004--layer5.netlify.app/cloud-native-management/meshery/integrations/devfile

@leecalcote
Copy link
Member

Thank you.

@iArchitSharma iArchitSharma merged commit 611b3b5 into layer5io:master Apr 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Screenshots] Devfile under 'How it Works See It in Action' section
5 participants