-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devfile screenshots #5384
Devfile screenshots #5384
Conversation
Signed-off-by: Narasimha <[email protected]>
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit 8ae83b8 at: https://65c4fdf93838cf2396dd18bc--layer5.netlify.app |
Hi @narasimha-1511 , You're welcome at the meeting Check to community calendar for more details of meetings at Layers. |
@narasimha-1511, I guess you already know what needs to be changed here 😉 |
Signed-off-by: Narasimha <[email protected]>
changes done @saurabh100ni 😄 |
🚀 Preview for commit f3b9cfe at: https://65cc7c304419d787fb0f8004--layer5.netlify.app |
@narasimha-1511, do you know what we do with that checkbox in PR description 👀? |
I have Signed my commits 😅 . |
hey @vishalvivekm this PR LGTM can you merge it? |
this PR LGTM @iArchitSharma |
@@ -15,8 +15,8 @@ featureList: [ | |||
"Central location management so updates can be applied once and be properly aligned across development teams." | |||
] | |||
workingSlides: [ | |||
../_images/meshmap-visualizer.png, | |||
../_images/meshmap-designer.png | |||
../_images/meshmap-designer.png, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narasimha-1511 aren't the images supposed to be inside _images/devfile
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are inside devfile folder these images are automatically used in the integration from the folder you can see it here:https://65cc7c304419d787fb0f8004--layer5.netlify.app/cloud-native-management/meshery/integrations/devfile
Thank you. |
Description
Please Review my PR
This PR fixes #4886
Notes for Reviewers
Signed commits