-
Notifications
You must be signed in to change notification settings - Fork 112
Add missing actions to comment history panel #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: LSUDOKO <[email protected]>
|
||
### Commenting via hotkey | ||
|
||
<button class="kbc-button kbc-button-xs">M</button> Add a comment into your design when you press "M" as the hotkey. After pressing the hotkey, a new comment will be displayed. You can move the new comment anywhere in your design. | ||
`M` Add a comment into your design when you press "M" as the hotkey. After pressing the hotkey, a new comment will be displayed. You can move the new comment anywhere in your design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change, please.
- <button class="kbc-button kbc-button-xs">Ctrl + C</button> / <button class="kbc-button kbc-button-xs">Ctrl + V</button>: Copy and paste | ||
- <button class="kbc-button kbc-button-xs">Ctrl + Z</button>: Undo the action | ||
- **Keyboard Shortcuts**: - `Ctrl + C` / `Ctrl + V`: Copy and paste | ||
- `Ctrl + Z`: Undo the action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert these changes.
Feedback given. I think it would be ideal if those actions that you describe are not done so strictly in context of the comment history panel, but are described at-large as each of those actions are available outside of the comment history panel as well. |
Hi @LSUDOKO😊, are you still working on this, or have you encountered any problems? |
@LSUDOKO, are you still working on this PR? |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
@zihanKuang with no word from @LSUDOKO, please take over this PR and complete it or close it. |
Apologies for the delay. I'm currently away from home for my college summer vacation and don't have access to my laptop. I’ll be able to address this issue after June 11, if that is okay with you |
This PR fixes #549
The documentation now properly reflects all the recent advancements in the comment history panel functionality, including appropriate warnings about permanent actions like deletion and guidance on when to use each action.