docs(claude): add verify-upstream-before-patching rule#194
Merged
Conversation
Distill a recurring lesson into a durable rule: before patching third-party code that lives inside a project (vendored library, custom-node tarball, fork checkout), check upstream master and closed issues first. A 30-second `gh api` lookup often reveals the fix already shipped in a newer release, avoiding both wasted local patches and duplicate upstream PRs. The rule covers the quick `gh` lookup recipes, the cases where it matters most (tarball-installed packs without `.git`, diverged forks, generated files), and explicit skip conditions so it doesn't add friction to first-party work. Surfaced from a ComfyUI custom-node debugging session where the local install was 33 versions behind upstream master and both bugs the author was about to PR were already fixed. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exact_dot_claude/rules/verify-upstream-before-patching.md— a durable rule to check upstream master + closed issues viagh api/gh issue viewbefore patching vendored or installed third-party code..git(the surfacing case), diverged forks, and generated files; explicit skip conditions to avoid friction on first-party work.Test plan
chezmoi diff ~/.claude/rules/verify-upstream-before-patching.mdclean (source ↔ target in sync)🤖 Generated with Claude Code