feat: Add HttpTransport trait abstraction #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a generic HttpTransport trait to decouple the SDK from specific HTTP client implementations. This follows the pattern established in eventsource-client. - Add transport.rs with HttpTransport trait and error types - Add transport_hyper.rs with hyper 1.0 implementation - Make hyper an optional dependency via feature flags - Use Bytes for request bodies (supports binary and empty) - Stream response bodies via ByteStream type alias This commit adds the abstraction without changing existing code. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
kinyoklion
reviewed
Jan 12, 2026
| default = ["rustls"] | ||
| rustls = ["hyper-rustls", "launchdarkly-server-sdk/rustls"] | ||
| default = ["hyper-rustls"] | ||
| hyper-rustls = ["dep:hyper-rustls", "launchdarkly-server-sdk/hyper-rustls"] |
Member
There was a problem hiding this comment.
Is changing this feature name going to be a problem compatibility wise?
Member
There was a problem hiding this comment.
Or was this a new feature to the branch?
Member
Author
There was a problem hiding this comment.
This is getting merged into a separate branch that will become 3.x once the rest of the stuff is done. So I expect to break backwards compatibility with this.
kinyoklion
reviewed
Jan 12, 2026
Member
There was a problem hiding this comment.
I assume this is basically the same as the event source one?
kinyoklion
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a generic HttpTransport trait to decouple the SDK from specific HTTP client implementations. This follows the pattern established in eventsource-client.
This commit adds the abstraction without changing existing code.