feat: add svelte example project and improving SDK docs#722
Merged
abarker-launchdarkly merged 28 commits intolaunchdarkly:feat/svelte-sdk-examplefrom May 14, 2025
Merged
Conversation
intial refactor to use new "@launchdarkly/js-client-sdk"
…improve initialization logic
[refactor] Update SvelteLDClient to use proxy for flag variations. Allows to track flag evaluations
…js-core into feat/svelte-sdk
…ization with user context
…ents refactor: update SvelteLDClient to use compat SDK and improve initial…
…e error handling in example
nosnibor89
changed the title
abarker-launchdarkly
changed the base branch from
main
to
feat/svelte-sdk-example
abarker-launchdarkly
approved these changes
May 14, 2025
Member
abarker-launchdarkly
left a comment
abarker-launchdarkly
left a comment
There was a problem hiding this comment.
@nosnibor89 Thank you for the contribution. This all looks good but I'm first merging to a temporary holding branch to make a few editorial changes to the README to make it more consistent with our other documentation.
abarker-launchdarkly
merged commit 0b51885
into
launchdarkly:feat/svelte-sdk-example
1 check passed
abarker-launchdarkly
added a commit
that referenced
this pull request
May 15, 2025
The contributed work was already reviewed in the original PR (#722) which was merged into this temporary holding branch to: - Standardize the README files to be consistent with our other documentation - Add the build/test github action workflow for the Svelte SDK Only the changes made in commit 79b42ae need to be reviewed. --------- Co-authored-by: Robinson Marquez <robinsonmadrid@outlook.com> Co-authored-by: Robinson Marquez <nosnibor1989@gmail.com> Co-authored-by: Robinson Marquez <robinsonmarquez@robinsonmarquezm4.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
No issue.
Describe the solution you've provided
This pull request introduces a new Svelte example project to demonstrate the usage of
@launchdarkly/svelte-client-sdk. The README of the example project includes steps to run such application that internally uses the SDK to interact with a boolean flag.Also, this PR adds documentation for
@launchdarkly/svelte-client-sdkitself with a "Getting Started" session along with more advanced use of the SDK's api.Describe alternatives you've considered
I don't know what to write here.
Additional context
This is a follow up PR for #632. Where Svelte SDK was introduced.
After this, follow up PR for technical debt(upgrade Svelte 5 and improving test coverage ) should be expected