ci: split release-please into independent release and PR creation steps#107
Closed
keelerm84 wants to merge 2 commits into
Closed
ci: split release-please into independent release and PR creation steps#107keelerm84 wants to merge 2 commits into
keelerm84 wants to merge 2 commits into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
approved these changes
Apr 6, 2026
Contributor
|
Closing: The split release-please pattern is only needed for repos with artifact uploads. This attestation-only repo doesn't need it. The attestation changes are in PR #106. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Follows the pattern established in ld-relay PR #622 to support GitHub's immutable releases.
Describe the solution you've provided
Splits the single
release-packagejob into two jobs (release-please+release-package) and uses a two-pass release-please invocation:skip-github-pull-request: true): Attempts to create a release. If successful, checks out the repo and pushes the tag explicitly (with an idempotency guard).skip-github-release: true): Only runs if no release was created. Handles PR creation/maintenance.release-packagejob: Runs only whenreleases_created == 'true', containing all build/publish/attest steps without per-stepifguards.This separation is required because release-please checks for an existing tag to decide whether a release PR is still needed. Without the split, it could open a duplicate PR before the tag is available.
Items requiring careful review:
update-cabalstep now referencessteps.release-prs.outputs.pr(from pass 2) instead of the oldsteps.release.outputs.pr(from pass 1). Since pass 1 usesskip-github-pull-request: true, it won't emit PR outputs — soupdate-cabalmust use the pass 2 step ID. Verify this is correct.update-cabaldoes not usefetch-depth: 0(unlike therelease-packagejob checkout). Confirmupdate-cabaldoesn't require full history.update-cabalnow only runs when no release was created (since pass 2 is skipped on release runs). Previously it ran whenever a PR existed, even during a release run. This should be fine (no PR to update during a release), but worth confirming.Describe alternatives you've considered
Could keep a single job with per-step
ifconditions, but splitting into two jobs follows the established pattern across the org and makes the release-please logic self-contained.Additional context
16a9c90856f42705d54a6fda1823352bdc62cf38is unchanged; only the version comment was updated from# v4to# v4.4.0.release-packagejob dropspull-requests: writesince it no longer runs release-please.Link to Devin session: https://app.devin.ai/sessions/7d5bda4d9dbe4ae0b950b30a50485e60
Requested by: @keelerm84
Note
Medium Risk
Changes the release workflow control flow (two-pass
release-please, manual tag creation, and a new gated packaging job), which could impact how/when releases and release PRs are created. No product code changes, but misconfiguration could break releases or create missing/duplicate tags/PRs.Overview
Splits the GitHub Actions release workflow into two jobs: a
release-pleasejob that decides whether to cut a GitHub Release or open/update a release PR, and arelease-packagejob that runs build/publish/attestation only when a release was actually created.release-pleaseis now invoked twice: first to create the GitHub Release (with PR creation disabled) and, on success, explicitly creates/pushes the git tag with an idempotency check; second (only when no release was created) to manage release PRs and runupdate-cabalagainst the PR branch.Reviewed by Cursor Bugbot for commit 407a6be. Bugbot is set up for automated code reviews on this repo. Configure here.