chore: Update contract-tests action to v1.3.0 and pass token to SSE step#264
Merged
Merged
Conversation
Bumps the SDK contract-tests action from v1.0.1 to v1.3.0 and replaces the inline SSE downloader curl with the same action, so the GitHub token is passed through to both steps and avoids rate limiting on the downloader script.
tanderson-ld
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchdarkly/gh-actions/actions/contract-testsfromcontract-tests-v1.0.1tocontract-tests-v1.3.0for the SDK contract tests step.curl ... | shSSE downloader invocation with the samecontract-tests@contract-tests-v1.3.0action (repo: sse-contract-tests,branch: v2.0.0,version: v2,debug_logging: true,enable_persistence_tests: false) so the existing harness version is preserved.token: ${{ inputs.github_token }}to the SSE step so the downloader script and harness fetch are no longer subject to anonymous GitHub API rate limits.enable_persistence_tests: falseto the SDK contract tests step to preserve the previous behavior, since v1.2.0+ flips the default totrue.Note
Medium Risk
Moderate CI risk: updates external GitHub Action versions and changes how SSE contract tests are invoked, which could alter test execution or fail due to action/harness behavior changes.
Overview
Updates the shared CI composite to run contract tests via
launchdarkly/gh-actions/actions/contract-tests@contract-tests-v1.3.0(fromv1.0.1) and explicitly disables persistence tests to preserve prior behavior.Replaces the inline SSE harness
curl | shinvocation with the samecontract-testsaction (pinningsse-contract-testsv2.0.0/v2) and passestoken: ${{ inputs.github_token }}to avoid anonymous GitHub API rate limits.Reviewed by Cursor Bugbot for commit f83277b. Bugbot is set up for automated code reviews on this repo. Configure here.