chore: Update cowlib for contract tests to work with OTP 28.#177
Merged
Conversation
kinyoklion
commented
Apr 16, 2026
| ldclient | ||
| ]}. | ||
|
|
||
| %% Overridden for: https://github.com/ninenines/cowboy/issues/1670 |
Member
Author
There was a problem hiding this comment.
I wouldn't want to do this in the SDK, but for the contract tests I think unconstraining this is likely fine.
keelerm84
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Dependency upgrade of the HTTP server library plus overridden dependency resolution could introduce subtle runtime or build differences in the test service, especially around Cowboy/Ranch integration.
Overview
Updates
test-serviceto usecowboy2.14.2(from2.8.0) to improve compatibility with newer OTP versions.Adds a
rebar.configoverridesblock that forcescowboyto resolve withcowlibandranch, as a workaround for ninenines/cowboy#1670 and olderrebar3behavior.Reviewed by Cursor Bugbot for commit c3a1e03. Bugbot is set up for automated code reviews on this repo. Configure here.