chore: Update sdk_metadata features#170
Merged
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
Member
|
The CI issues are independent, so those will be in another PR. |
Contributor
Author
|
Thanks for confirming! |
5 tasks
keelerm84
approved these changes
Feb 13, 2026
kinyoklion
added a commit
that referenced
this pull request
Feb 13, 2026
**Requirements** - [x] I have added test coverage for new or changed functionality — N/A, CI infrastructure change only - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions — N/A, CI infrastructure change only **Related issues** Fixes the CI failure in [PR #170](#170) where all three "Build and Test" matrix jobs fail at the Redis setup step. **Describe the solution you've provided** Updates the pinned SHA for `supercharge/redis-github-action` in `.github/actions/ci/action.yml` from v1.8.0 (`ea9b21c...`) to v1.8.1 (`bc274cb...`). The v1.8.0 Docker container action bundles a Docker client using API version 1.40, which is now incompatible with the Docker daemon on `ubuntu-24.04` runners (minimum API version 1.44). This causes the error: ``` docker: Error response from daemon: client version 1.40 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version. ``` **Human review checklist** - [ ] Verify `bc274cb7238cd63a45029db04ee48c07a72609fd` corresponds to the [v1.8.1 release](https://github.com/supercharge/redis-github-action/releases/tag/1.8.1) of `supercharge/redis-github-action` - [ ] Confirm CI passes with the updated action **Describe alternatives you've considered** Could replace the action entirely with a raw `docker run` step for Redis, but updating to the latest release is the simplest and least disruptive fix. **Additional context** - Link to Devin run: https://app.devin.ai/sessions/6ca703ca90bb4f6795aa4922d3f5251a - Requested by: rlamb@launchdarkly.com --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
kinyoklion
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A
Describe the solution you've provided
Adds a
featuresmap to.sdk_metadata.jsonlisting all features the Erlang Server SDK supports, with their introduction versions. Features were identified by cross-referencing:16 features are included (alphabetical):
allFlags,appMetadata,contexts,experimentation,fileDataSource,inlineContextCustomEvents,inlineContextEvaluationEvents,offlineMode,privateAttrs,relayProxyDaemon,relayProxyProxy,storingData,storingDataRedis,testDataSource,track,variationDetail.Items for reviewer attention:
fileDataSourceversion is1.2, not1.0as the docs table states. The CHANGELOG clearly shows file data source was added in v1.2.0, not v1.0.0. This appears to be a docs table error.inlineContextEvaluationEventsat3.2was identified from the CHANGELOG (v3.2.0: "Always inline contexts for feature events") but is not explicitly listed as a row in the docs table. The docs table only has "Inline contexts in custom events" as a row. Verify this is a correct addition.storingDataRedisat1.0was added alongside the genericstoringDatasince Redis is the only persistent store the SDK supports (added in v1.0.0 per CHANGELOG). Verify both entries are desired.experimentationat1.2: The docs table says 1.2. Basic experimentation support (track_with_metric) existed since pre-release, but 1.2 added experiment traffic allocation. Confirm 1.2 is the correct version.Describe alternatives you've considered
Could have used the docs table version of
1.0forfileDataSourceverbatim, but the CHANGELOG evidence is clear that the feature was introduced in 1.2.0.Additional context