Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openpgp v5 #225

Closed
Closed

Conversation

dror-weiss
Copy link

I'm trying to make this library work with bun instead of node, and I think the only thing in the way is openpgp v4.
Regardless of whether it will work, I submit a PR with some necessary changes to make it work with the significant API change.

  • I have a single failing test in the expected value in src/env-directive.test.ts:100:29 (expected: 2 received: 1) that I don't think is related to my changes.

@dror-weiss
Copy link
Author

@joelgallant, I hope you are the person to ping this PR to.

@daniel-heppner-ibigroup

I think I am in need of this fix as well. Currently having trouble deploying to Vercel in a Remix project because of an issue with asn1.js missing, which I believe is a problem with openpgp v4.
Also mentioned here: #208 (comment)

@dror-weiss
Copy link
Author

@daniel-heppner-ibigroup , I came back here due to lambda asn1.js error and was amazed to see this wasn't merged.
I'm not sure this repo is active anymore, which means we will need to find another solution.

@daniel-heppner-ibigroup

@dror-weiss I ended up deciding it's better to just avoid these config libraries altogether, and just use Typescript for the configuration.

@dror-weiss dror-weiss closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants