-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fixes security vulnerability from url package dependency by updating url package version #3876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi. This is in fact a breaking change. However it seems like this should be OK to merge in Current (main):
From Main (bab1b02):
Your change:
With output similar to the CI/CD pipeline failures.
|
It shouldn't be a breaking change if The PR title seems misleading. If you did |
Thanks, I initially followed up on the Rust discord server in the off-topic channel to ensure I'm following proper protocol. I did run a cargo update on the package and used that to generate the updated Cargo.lock file, however, I did not confirm the MSRV version which as confirmed from the logs is causing the examples, checks, integration and CI tests to fail. I'm not as familiar with cargo as I'd like to be but this information is a great step in the right direction. Apologies but this is my first PR in Rust and I would love to add documentation on how/if these checks can be validated locally[/in the forked repo] before PRs have been raised for the community to review which may reduce some of the friction that the community might be observing while a fresh set of eyes, like my own is onboarding. For next steps, I'll pull from the Edit: PR stems from my efforts to bump url package to resolve the linked dependency issue in the description of the PR, while I want to play a bigger role, this security vulnerability seemed like a good place to start since it required minimal and simple changes with great upsides for everyone |
I overwrote multiple commits and force pushed those to my personal fork. |
Does your PR solve an issue?
Updates dependency on url package which has a transitive dependency on idna package where the vulnerability exists.
More details are available in the provided link.
GHSA-h97m-ww89-6jmq
Is this a breaking change?
No, the integration tests and build succeeds without any issues.
The updated package is also known to maintain backward compatibility without any breaking changes.