fix: PgConnectOptions docs #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
fix/docs
branch
3 times, most recently
from
f430a00 to
8c4b663
Compare
|
I'm going to merge this so you get the attribution, but the release is going to have pretty significant wording changes since this could be blended better with the rest of the doc comment. |
|
As it turns out, the handling of I'm not sure whether to fix that or leave it as-is. |
abonander
added a commit
that referenced
this pull request
Apr 14, 2025
abonander
added a commit
that referenced
this pull request
Apr 14, 2025
* chore: prepare 0.8.4 release * fix(postgres): send `limit: 0` for all `Execute` messages fixes #3673 * fix: let `CertificateInput::from` infer any PEM-encoded document #3809 (comment) * doc: improve documentation of `PgConnectOptions` fixes #3740 * chore: update CHANGELOG from PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note I'm PRing this to document the current behavior, I'm not sure if it was the intention of the original author to support MORE behavior than
libpqoffers.If I look at
pub fn ssl_client_key(self, key: impl AsRef<Path>) -> PgConnectOptionsthere is no way to "set" the inline version ofCertificateInput, it only accepts the file version. This potentially should be lifted for symmetry with the environment variables.This may not be the intention? But also I seen no reason to artificially constrain
sqlx-postgresto libpq behavior, in lots of scenarios (single file lambda binary) its much better to be able to set the certificate inline.Regardless of what the desired final behavior is: This PR just documents the status quo, even if we wish to change it in the future.
Is this a breaking change?
no