chore: remove dead daemon auto-policy knobs (deleted in ao-cli v0.5.13)#1
Merged
Merged
Conversation
ao-cli v0.5.13 deleted the daemon auto_merge / auto_pr / auto_commit_before_merge / auto_prune_worktrees policy fields end-to-end; they were parsed and persisted but never executed. Drop the read-only toggles from the Daemon settings page and point users at workflow post_success.merge, which is where merge/PR policy actually lives (executed by the workflow-runner plugin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ao-cli v0.5.13 deleted the daemon
auto_merge/auto_pr/auto_commit_before_merge/auto_prune_worktreespolicy fields end-to-end. They were parsed and persisted but never executed; the daemon now silently drops these keys into an ignoredextramap. Merge/PR policy lives in workflow YAMLpost_success.merge, executed by the workflow-runner plugin.What changed
Automationtoggles (auto_merge_enabled,auto_pr_enabled,auto_commit_before_merge,auto_prune_worktrees_after_merge) fromDaemonConfigPageinsrc/app/settings-pages.tsx, along with the now-unusedDAEMON_SETTINGStable,ToggleRowcomponent, andSeparatorimport.ao daemon config --auto-merge true/falsefooter note with an informational note pointing at workflowpost_success.merge, matching the existing note style.Auto Mergecheckbox in the workflow builder (builder-pages.tsx) untouched — that is workflow-levelpost_success.auto_merge, which is still live.GraphQL layer
No upstream schema cleanup needed: the daemon toggles had no GraphQL plumbing at all (they were hardcoded
checked={false}with no query backing).animus-transport-graphqldoes not expose these daemon fields.Checks
npm run test: 53/53 passnpm run lint/npm run typecheck: no new issues introduced (pre-existing errors on main are unchanged — same counts before/after)npx vite buildsucceeds; notenpm run build'scheck:performance-budgetsstep resolves../../embedded/index.htmlrelative to the repo, which does not exist on a fresh clone — pre-existing, unrelated to this change.🤖 Generated with Claude Code