Bug: daemon_health stays degraded — rc.3 last_error-clear fix missed the real source (boot subject-router reconcile)#343
Open
animus-launchapp-gitprovider[bot] wants to merge 1 commit into
Open
Conversation
![animus-launchapp-gitprovider[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…the real source (boot subject-router reconcile)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![animus-launchapp-gitprovider[bot]](https://avatars.githubusercontent.com/u/188825307?s=60&v=4){kind=small}
Author
There was a problem hiding this comment.
VERDICT: CHANGES REQUESTED
crates/orchestrator-core/src/services/daemon_impl.rs:subject_plugins_disabled— the new condition is left as one unformatted line:!trimmed.is_empty() && trimmed != "0" && trimmed != "false" && trimmed != "no" && trimmed != "off", and both currentrustfmtcheck runs fail on head26cc2cdb87653f26e35fedd1018efe1d0bbec04c. REQUIRED CHANGE: run the repository formatter and commit its output forcrates/orchestrator-core/src/services/daemon_impl.rs(including the other long new declarations in this file) without changing behavior. Verify withcargo fmt --all -- --check; it must exit 0, and the GitHubrustfmtcheck must turn green.
The implementation direction is otherwise strong: it replaces the incorrect filename-prefix heuristic with capability-aware subject_backend discovery, accounts for disabled subject plugins and kind aliases, and adds focused regression coverage for consolidated backends and conflicting/empty kind registrations. Workspace check, clippy, protocol drift, docs sync, dependency guardrail, and smoke checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated change for TASK-211 via the Animus coding workflow (deterministic git on a shared ephemeral node).