Broker honors workflow-level environment so a run shares ONE node (rc.16, REQ-051)#327
Merged
Shooksie merged 1 commit intoJul 15, 2026
Conversation
The daemon's EnvironmentBroker gate (configure_environment_broker) resolved the run environment from kind-level routing rules only, passing workflow_env=None. On deployments whose only environment config is workflow-level (workflows[].environment), resolve_environment returned None -> broker disengaged -> each per-phase runner prepared its OWN ephemeral node -> code-implement's edit never reached code-open-pr's workspace (no diff -> no PR). Thread a workflow-id -> environment map into ProcessManager (populated in daemon_run alongside environment_routing) and feed the dispatch's workflow-level environment as workflow_env, mirroring how the runner resolves each phase. A workflow with an environment: now engages the broker (keyed per subject) so every phase shares one node. Workflows without an environment stay local. Bump orchestrator-cli 0.7.0-rc.16. TASK-431 / REQUIREMENT-051.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TASK-431: coding-workflow phases each ran on a SEPARATE ephemeral node, so code-open-pr saw no changes and opened no PR.
Root cause:
ProcessManager::configure_environment_brokergated the daemon broker onresolve_environment(subject_kind, None, None, /*workflow_env=*/None, environment_routing). On deployments whose only environment config is workflow-level (workflows[].environment, no kind-level routing rule), that returnsNone→ broker disengages → each per-phase runner prepares its own node → no shared workspace.Fix: thread a workflow-id → environment map into
ProcessManager(populated indaemon_runnext toenvironment_routing) and pass the dispatch's workflow-level environment asworkflow_env, mirroring how the runner resolves each phase. A workflow with anenvironment:now engages the broker (keyed per subject) so all phases share one node; workflows without one stay local.Verified: touched crates compile; daemon-runtime lib tests show the same 293-pass/27-fail as the clean rc.15 base (pre-existing test-isolation failures, unrelated). Bump orchestrator-cli 0.7.0-rc.16. REQUIREMENT-051.