feat(stake): add --relay for MEV Shield outer signer on stake commands#918
Open
claytonlin1110 wants to merge 1 commit intolatent-to:stagingfrom
Open
feat(stake): add --relay for MEV Shield outer signer on stake commands#918claytonlin1110 wants to merge 1 commit intolatent-to:stagingfrom
claytonlin1110 wants to merge 1 commit intolatent-to:stagingfrom
Conversation
Author
|
@thewhaleking Hi, my first contribution here, Would you please review and comment feedback? Thanks. |
Author
|
@ibraheem-abe Sorry for pinging as i'm not sure who is the reviewer here... Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements --relay for btcli stake add/remove/move/transfer/swap commands to allow a separate coldkey (“relay”) to sign the outer MevShield.submit_encrypted extrinsic, while the staking coldkey continues to sign the inner staking extrinsic.
Closes #824
Motivation
Some users need operational separation:
User-facing Changes
New CLI flag
--relay <wallet name | coldkey SS58>
Commands updated
Validation / Rules
If --relay is used with --no-mev-protection, the CLI fails with an error.
coldkey SS58: must match a coldkey present under that wallet path,
wallet name: must exist as a wallet directory under that wallet path.
Testing