Add basic support for Vue 3 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelinn
reviewed
Sep 19, 2023
| @@ -1,6 +1,10 @@ | |||
|
|
|||
| import { ApplicationInsights, Util } from '@microsoft/applicationinsights-web' | |||
|
|
|||
There was a problem hiding this comment.
Util.generateW3CId() got removed in v2.6.0.
Add import { generateW3CId } from '@microsoft/applicationinsights-core-js' instead.
There was a problem hiding this comment.
I have created a separate PR for this as it does not relate to the Vue 3 compatibility.
WebDevTmas
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Vue 3 now sends in an object and not a function when setting up a plugin, there is an error thrown from using the .prototype call in the install function. This PR identifies if Vue 3 is being used, and if that is the case it uses Vue.provide('appInsights'... to make appInsights available to other parts of the application.