Fixed two deprecations warning, about "path" attribute type and default "target-property" in Marko Taglib #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marko Taglib deprecated the attribute type which was "path". Now it's standardized to use "string" also for paths. The deprecation warning doesn't appear again.
I just made a small mistake and forgot to change package-path's type too. Also, this caused another warning which was about default "target-property" for "*" attributes. I just put "target-property": "*" for the two "*" attributes in the json. Deprecations warning are no more, yay!
|
Is there a change missing? Still getting the target-property warning. |
|
Sadly they are! I forgot a commit. I'm gonna commit again soon tomorrow to fix that. |
Again, I just forgot to do this in the last commit. Whoops.
|
@bruce808 fixed. |
|
cc @mlrawlings @DylanPiercey Would be great to get this merged! |
|
That would be cool, but this lib doesn't seem in active development anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marko Taglib deprecated the attribute type which was
"path".Now it's standardized to use
"string"also for paths.I just changed the
"path"types to"string"ones.There also was another deprecation warning which was about
"*"attributes: the default"target-property"will not be"*"anymore but null in the future, so it needs to explicitly be declared. I did so, in the two"*"attributes.The deprecation warning doesn't appear again.
Everything works fine.