Fix: corrects the IESG evaluation record summary for approved docs (i…

…etf-tools#4261) * fix: corrects the IESG evaluation record summary statement for documents where the IESG state is approved (announced or not). * fix: corrects IESG evaluation record summary for approved docs This is a correction to a previous fix that didn't pass all the tests for some documents * fix: corrects IESG evaluation record summary for approved docs Corrects the previous fix by removing commented out code. Sigh. At least these are free.
larseggert · Jul 24, 2022 · 3a1d8b3 · 3a1d8b3
1 parent f58033e
commit 3a1d8b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ietf/doc/views_doc.py b/ietf/doc/views_doc.py
@@ -1216,6 +1216,8 @@ def document_ballot_content(request, doc, ballot_id, editable=True):
         else:
             position_groups.append(g)
 
+    iesg = doc.get_state("draft-iesg")
+    iesg_state = iesg.slug if iesg else None
     if (ballot.ballot_type.slug == "irsg-approve"):
         summary = irsg_needed_ballot_positions(doc, [p for p in positions if not p.is_old_pos])
     else:
@@ -1241,6 +1243,7 @@ def document_ballot_content(request, doc, ballot_id, editable=True):
                                    deferred=deferred,
                                    summary=summary,
                                    all_ballots=all_ballots,
+                                   iesg_state=iesg_state,
                                    ),
                               request=request)
 

diff --git a/ietf/templates/doc/document_ballot_content.html b/ietf/templates/doc/document_ballot_content.html
@@ -39,7 +39,7 @@
                 </p>
             {% endif %}
         {% endif %}
-        {% if not ballot_open %}
+        {% if not ballot_open or iesg_state == "ann" or iesg_state == "approved" %}
             <p class="alert alert-warning my-3">
                 <b>Note:</b> This ballot was opened for revision {{ ballot.rev }} and is now closed.
             </p>