Skip to content

Conversation

@batkru
Copy link
Contributor

@batkru batkru commented Dec 8, 2014

This fix prevents deleting under a very sensitive condition.

@larryryu
Copy link
Owner

larryryu commented Dec 8, 2014

I don't think this is necessary because if the swipe was fast/violent enough we can treat that as an intent to delete. You can also adjust the "deletionVelocityTresholdValue" value to a more suitable setting. What do you think?

@batkru
Copy link
Contributor Author

batkru commented Dec 8, 2014

The main reason I put this is since when in horizontal mode with cells that are full screen when users swipe from left to right, sometimes the gesture is triggered without them really wanting to actually trigger (their thumb sometimes goes in angles that are not necessarily completely horizontal). Adding this fixed the behavior and users stopped complaining as the gesture was only really triggered when the distance met the threshold. I leave it up to you to verify and decide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants