Do not expose HISTDB_FILE path via ps
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does look neater. I can't think of a reason why it would be a problem, but I will give it a little time to percolate in my brain just in case. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for spamming the PRs 😅. Anyway, this is a "nice to have", not an issue per-se, so I'll understand if it's of no interest to you to merge.
I prefer not to expose the full path of
$HISTDB_FILEto process monitors. The use case for this is shared systems mostly where I might not want to expose the full path to the file. With this PR, the following:becomes:
It's just neater (IMO) and doesn't expose custom paths if I were to load it from another place.