fix(php): ignore warnings in CLI parsing #1527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running PHP with extensions like imagick, sometimes the extension needs a rebuild after `brew upgrade`. Otherwise, it will throw a warning: ``` Warning: Version warning: Imagick was compiled against ImageMagick version 1809 but version 1810 is loaded. Imagick will run but may behave surprisingly in Unknown on line 0 ``` This warning is also printed, within the shell executions in Valet. But we use the output of those PHP CLI invocations. With those warnings being printed out, the parsing on the output fails and Valet cannot be used until the pecl extension is rebuilt. With this patch, all CLI PHP invocations use ` -d error_reporting=1`. This suppresses warnings, but will still report errors. It makes valet more robust in case a system package update causes warnings.
|
Looks good to me initially. @drbyte any concerns before I merge? |
|
This is probably the best-available approach. We can't automate the re-install of all possible extensions without adding a lot of complexity due to unpredictability. And suppression of warnings (to prevent undesired excess verbage) but not errors (where we do want a failure to be reported) makes the best sense, particularly in the use-cases where this PR has introduced changes (where Valet is asking PHP for some information that's largely unaffected by and immaterial to any warnings PHP itself may be encountering). So @mattstauffer I'll give it a yes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running PHP with extensions like imagick, sometimes the extension needs a rebuild after
brew upgrade. Otherwise, it will throw a warning:This warning is also printed, within the shell executions in Valet. But we use the output of those PHP CLI invocations. With those warnings being printed out, the parsing on the output fails and Valet cannot be used until the pecl extension is rebuilt.
With this patch, all CLI PHP invocations use
-d error_reporting=1. This suppresses warnings, but will still report errors.It makes valet more robust in case a system package update causes warnings.