feat: add Poll component to standardize polling behavior #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Centralizes interval-based logic in reusable Vue component - Reduces polling frequency to hourly when window not visible - Improves code maintainability and reduces redundancy
- Centralizes interval-based logic in reusable Vue component - Reduces polling frequency to hourly when window not visible - Improves code maintainability and reduces redundancy
- Centralizes interval-based logic in reusable Vue component - Reduces polling frequency to hourly when window not visible - Improves code maintainability and reduces redundancy
- Centralizes interval-based logic in reusable Vue component - Reduces polling frequency to hourly when window not visible - Improves code maintainability and reduces redundancy
bert-w
reviewed
May 23, 2025
| @@ -0,0 +1,111 @@ | |||
| <script type="text/ecmascript-6"> | |||
There was a problem hiding this comment.
I'd rewrite this as a plain javascript function and not a vue component. Now every polling function needs an associated html element in the DOM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces the bandwidth usage when the browser tab is not active.