[12.x] Moving redis integration tests #57860
Merged
+96
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
vadimonus
force-pushed
the
moving-redis-integration-tests
branch
3 times, most recently
from
2762b77 to
1666fc7
Compare
vadimonus
force-pushed
the
moving-redis-integration-tests
branch
from
1666fc7 to
cdd729c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisCacheIntegrationTest is located outside of Integration folder and is not called with all possible redis configurations. Moving it to Integration folder.
Extracted PhpRedisBackoffTest from RedisCacheIntegrationTest, as it covers not cache, but only RedisConnector specific option
Also setting CACHE_STORE=redis for Redis integration tests to be sure current and future tests use RedisStore and not default ArrayStore (defined in vendor/orchestra/testbench-core/laravel/config/cache.php)